Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

rtc: pm8xxx: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20230304133028.2135435-26-u.kleine-koenig@pengutronix.de
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>

authored by

Uwe Kleine-König and committed by
Alexandre Belloni
3fc5029a c3d12a10

+2 -3
+2 -3
drivers/rtc/rtc-pm8xxx.c
··· 530 530 return 0; 531 531 } 532 532 533 - static int pm8xxx_remove(struct platform_device *pdev) 533 + static void pm8xxx_remove(struct platform_device *pdev) 534 534 { 535 535 dev_pm_clear_wake_irq(&pdev->dev); 536 - return 0; 537 536 } 538 537 539 538 static struct platform_driver pm8xxx_rtc_driver = { 540 539 .probe = pm8xxx_rtc_probe, 541 - .remove = pm8xxx_remove, 540 + .remove_new = pm8xxx_remove, 542 541 .driver = { 543 542 .name = "rtc-pm8xxx", 544 543 .of_match_table = pm8xxx_id_table,