Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drm/v3d: Add a note about OOM vs FLDONE, which may be racing on v3.3.

We deref v3d->bin_job in the work handler, but v3d->bin_job doesn't
actually hold a ref on the job.

v2: typo fix FRDONE -> FLDONE

Signed-off-by: Eric Anholt <eric@anholt.net>
Link: https://patchwork.freedesktop.org/patch/msgid/20190313235211.28995-1-eric@anholt.net
Reviewed-by: Dave Emett <david.emett@broadcom.com>

+2 -1
+2 -1
drivers/gpu/drm/v3d/v3d_irq.c
··· 87 87 if (intsts & V3D_INT_OUTOMEM) { 88 88 /* Note that the OOM status is edge signaled, so the 89 89 * interrupt won't happen again until the we actually 90 - * add more memory. 90 + * add more memory. Also, as of V3D 4.1, FLDONE won't 91 + * be reported until any OOM state has been cleared. 91 92 */ 92 93 schedule_work(&v3d->overflow_mem_work); 93 94 status = IRQ_HANDLED;