Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

hwmon: (sht15) Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new() which already returns void. Eventually after all drivers
are converted, .remove_new() is renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20230918085951.1234172-16-u.kleine-koenig@pengutronix.de
Signed-off-by: Guenter Roeck <linux@roeck-us.net>

authored by

Uwe Kleine-König and committed by
Guenter Roeck
a93a2c41 e44e1994

+2 -4
+2 -4
drivers/hwmon/sht15.c
··· 1017 1017 return ret; 1018 1018 } 1019 1019 1020 - static int sht15_remove(struct platform_device *pdev) 1020 + static void sht15_remove(struct platform_device *pdev) 1021 1021 { 1022 1022 struct sht15_data *data = platform_get_drvdata(pdev); 1023 1023 int ret; ··· 1033 1033 regulator_unregister_notifier(data->reg, &data->nb); 1034 1034 regulator_disable(data->reg); 1035 1035 } 1036 - 1037 - return 0; 1038 1036 } 1039 1037 1040 1038 static const struct platform_device_id sht15_device_ids[] = { ··· 1051 1053 .of_match_table = of_match_ptr(sht15_dt_match), 1052 1054 }, 1053 1055 .probe = sht15_probe, 1054 - .remove = sht15_remove, 1056 + .remove_new = sht15_remove, 1055 1057 .id_table = sht15_device_ids, 1056 1058 }; 1057 1059 module_platform_driver(sht15_driver);