Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

hwmon: (sch5636) Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new() which already returns void. Eventually after all drivers
are converted, .remove_new() is renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20230918085951.1234172-15-u.kleine-koenig@pengutronix.de
Signed-off-by: Guenter Roeck <linux@roeck-us.net>

authored by

Uwe Kleine-König and committed by
Guenter Roeck
e44e1994 d2904168

+2 -4
+2 -4
drivers/hwmon/sch5636.c
··· 367 367 SENSOR_ATTR_RO(fan8_alarm, fan_alarm, 7), 368 368 }; 369 369 370 - static int sch5636_remove(struct platform_device *pdev) 370 + static void sch5636_remove(struct platform_device *pdev) 371 371 { 372 372 struct sch5636_data *data = platform_get_drvdata(pdev); 373 373 int i; ··· 385 385 for (i = 0; i < SCH5636_NO_FANS * 3; i++) 386 386 device_remove_file(&pdev->dev, 387 387 &sch5636_fan_attr[i].dev_attr); 388 - 389 - return 0; 390 388 } 391 389 392 390 static int sch5636_probe(struct platform_device *pdev) ··· 513 515 .name = DRVNAME, 514 516 }, 515 517 .probe = sch5636_probe, 516 - .remove = sch5636_remove, 518 + .remove_new = sch5636_remove, 517 519 .id_table = sch5636_device_id, 518 520 }; 519 521