Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

fbdev/geode/lxfb: Use fbdev I/O helpers

Set struct fb_ops and with FB_DEFAULT_IOMEM_OPS, fbdev's initializer
for I/O memory. Sets the callbacks to the cfb_ and fb_io_ functions.
Select the correct modules with Kconfig's FB_IOMEM_HELPERS token.

The macro and token set the currently selected values, so there is
no functional change.

v3:
* use _IOMEM_ in commit message
v2:
* updated to use _IOMEM_ tokens

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
Acked-by: Helge Deller <deller@gmx.de>
Cc: Andres Salomon <dilinger@queued.net>
Link: https://patchwork.freedesktop.org/patch/msgid/20230803184034.6456-16-tzimmermann@suse.de

+2 -7
+1 -3
drivers/video/fbdev/geode/Kconfig
··· 13 13 config FB_GEODE_LX 14 14 tristate "AMD Geode LX framebuffer support" 15 15 depends on FB && FB_GEODE 16 - select FB_CFB_FILLRECT 17 - select FB_CFB_COPYAREA 18 - select FB_CFB_IMAGEBLIT 16 + select FB_IOMEM_HELPERS 19 17 select VIDEO_NOMODESET 20 18 help 21 19 Framebuffer driver for the display controller integrated into the
+1 -4
drivers/video/fbdev/geode/lxfb_core.c
··· 392 392 393 393 static const struct fb_ops lxfb_ops = { 394 394 .owner = THIS_MODULE, 395 + FB_DEFAULT_IOMEM_OPS, 395 396 .fb_check_var = lxfb_check_var, 396 397 .fb_set_par = lxfb_set_par, 397 398 .fb_setcolreg = lxfb_setcolreg, 398 399 .fb_blank = lxfb_blank, 399 - /* No HW acceleration for now. */ 400 - .fb_fillrect = cfb_fillrect, 401 - .fb_copyarea = cfb_copyarea, 402 - .fb_imageblit = cfb_imageblit, 403 400 }; 404 401 405 402 static struct fb_info *lxfb_init_fbinfo(struct device *dev)