Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

scripts: sphinx-pre-install: remove unnecessary double check for $cur_version

$cur_version is currently being tested twice with the first test
resulting in an unhelpful "$sphinx returned an error", not continuing to
the more helpful "$sphinx didn't return its version".

This patch removes the first test to return the more useful message.

Fixes: a8b380c379ef ("scripts: sphinx-pre-install: only ask to activate valid venvs")
Signed-off-by: Sebastian Muxel <sebastian@muxel.dev>
Signed-off-by: Jonathan Corbet <corbet@lwn.net>
Link: https://lore.kernel.org/r/20240827133224.160776-1-sebastian@muxel.dev

authored by

Sebastian Muxel and committed by
Jonathan Corbet
9b8a79f4 bc6cb620

-2
-2
scripts/sphinx-pre-install
··· 300 300 } 301 301 302 302 $cur_version = get_sphinx_version($sphinx); 303 - die ("$sphinx returned an error") if (!$cur_version); 304 - 305 303 die "$sphinx didn't return its version" if (!$cur_version); 306 304 307 305 if ($cur_version lt $min_version) {