Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

scsi: qedi: Fix a possible memory leak in qedi_alloc_and_init_sb()

Hook "qedi_ops->common->sb_init = qed_sb_init" does not release the DMA
memory sb_virt when it fails. Add dma_free_coherent() to free it. This
is the same way as qedr_alloc_mem_sb() and qede_alloc_mem_sb().

Fixes: ace7f46ba5fd ("scsi: qedi: Add QLogic FastLinQ offload iSCSI driver framework.")
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
Link: https://lore.kernel.org/r/20241026125711.484-3-thunder.leizhen@huawei.com
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

authored by

Zhen Lei and committed by
Martin K. Petersen
95bbdca4 c62c3042

+1
+1
drivers/scsi/qedi/qedi_main.c
··· 369 369 ret = qedi_ops->common->sb_init(qedi->cdev, sb_info, sb_virt, sb_phys, 370 370 sb_id, QED_SB_TYPE_STORAGE); 371 371 if (ret) { 372 + dma_free_coherent(&qedi->pdev->dev, sizeof(*sb_virt), sb_virt, sb_phys); 372 373 QEDI_ERR(&qedi->dbg_ctx, 373 374 "Status block initialization failed for id = %d.\n", 374 375 sb_id);