Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

scsi: qedf: Fix a possible memory leak in qedf_alloc_and_init_sb()

Hook "qed_ops->common->sb_init = qed_sb_init" does not release the DMA
memory sb_virt when it fails. Add dma_free_coherent() to free it. This
is the same way as qedr_alloc_mem_sb() and qede_alloc_mem_sb().

Fixes: 61d8658b4a43 ("scsi: qedf: Add QLogic FastLinQ offload FCoE driver framework.")
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
Link: https://lore.kernel.org/r/20241026125711.484-2-thunder.leizhen@huawei.com
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

authored by

Zhen Lei and committed by
Martin K. Petersen
c62c3042 bd656942

+1
+1
drivers/scsi/qedf/qedf_main.c
··· 2738 2738 sb_id, QED_SB_TYPE_STORAGE); 2739 2739 2740 2740 if (ret) { 2741 + dma_free_coherent(&qedf->pdev->dev, sizeof(*sb_virt), sb_virt, sb_phys); 2741 2742 QEDF_ERR(&qedf->dbg_ctx, 2742 2743 "Status block initialization failed (0x%x) for id = %d.\n", 2743 2744 ret, sb_id);