Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

iio: position: hid-sensor-custom-intel-hinge: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new() which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20230919174931.1417681-44-u.kleine-koenig@pengutronix.de
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

authored by

Uwe Kleine-König and committed by
Jonathan Cameron
94f2dab2 d93837b8

+2 -4
+2 -4
drivers/iio/position/hid-sensor-custom-intel-hinge.c
··· 342 342 } 343 343 344 344 /* Function to deinitialize the processing for usage id */ 345 - static int hid_hinge_remove(struct platform_device *pdev) 345 + static void hid_hinge_remove(struct platform_device *pdev) 346 346 { 347 347 struct hid_sensor_hub_device *hsdev = pdev->dev.platform_data; 348 348 struct iio_dev *indio_dev = platform_get_drvdata(pdev); ··· 351 351 iio_device_unregister(indio_dev); 352 352 sensor_hub_remove_callback(hsdev, hsdev->usage); 353 353 hid_sensor_remove_trigger(indio_dev, &st->common_attributes); 354 - 355 - return 0; 356 354 } 357 355 358 356 static const struct platform_device_id hid_hinge_ids[] = { ··· 369 371 .pm = &hid_sensor_pm_ops, 370 372 }, 371 373 .probe = hid_hinge_probe, 372 - .remove = hid_hinge_remove, 374 + .remove_new = hid_hinge_remove, 373 375 }; 374 376 module_platform_driver(hid_hinge_platform_driver); 375 377