Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

memcg: fix typo in kmemcg cache walk macro

The macro for_each_memcg_cache_index contains a silly yet potentially
deadly mistake. Although the macro parameter is _idx, the loop tests
are done over i, not _idx.

This hasn't generated any problems so far, because all users use i as a
loop index. However, while playing with an extension of the code I
ended using another loop index and the compiler was quick to complain.

Unfortunately, this is not the kind of thing that testing reveals =(

Signed-off-by: Glauber Costa <glommer@parallels.com>
Cc: Kamezawa Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: Johannes Weiner <hannes@cmpxchg.org>
Acked-by: Michal Hocko <mhocko@suse.cz>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

authored by

Glauber Costa and committed by
Linus Torvalds
91c777d8 631b0cfd

+1 -1
+1 -1
include/linux/memcontrol.h
··· 429 429 * the slab_mutex must be held when looping through those caches 430 430 */ 431 431 #define for_each_memcg_cache_index(_idx) \ 432 - for ((_idx) = 0; i < memcg_limited_groups_array_size; (_idx)++) 432 + for ((_idx) = 0; (_idx) < memcg_limited_groups_array_size; (_idx)++) 433 433 434 434 static inline bool memcg_kmem_enabled(void) 435 435 {