Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

mm: fix wrong comments about anon_vma lock

We use rwsem since commit 5a505085f043 ("mm/rmap: Convert the struct
anon_vma::mutex to an rwsem"). And most of comments are converted to
the new rwsem lock; while just 2 more missed from:

$ git grep 'anon_vma->mutex'

Signed-off-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Acked-by: Ingo Molnar <mingo@kernel.org>
Cc: Mel Gorman <mel@csn.ul.ie>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

authored by

Yuanhan Liu and committed by
Linus Torvalds
631b0cfd 249d9d9d

+2 -2
+1 -1
include/linux/mmu_notifier.h
··· 151 151 * Therefore notifier chains can only be traversed when either 152 152 * 153 153 * 1. mmap_sem is held. 154 - * 2. One of the reverse map locks is held (i_mmap_mutex or anon_vma->mutex). 154 + * 2. One of the reverse map locks is held (i_mmap_mutex or anon_vma->rwsem). 155 155 * 3. No other concurrent thread can access the list (release) 156 156 */ 157 157 struct mmu_notifier {
+1 -1
mm/mmap.c
··· 2943 2943 * vma in this mm is backed by the same anon_vma or address_space. 2944 2944 * 2945 2945 * We can take all the locks in random order because the VM code 2946 - * taking i_mmap_mutex or anon_vma->mutex outside the mmap_sem never 2946 + * taking i_mmap_mutex or anon_vma->rwsem outside the mmap_sem never 2947 2947 * takes more than one of them in a row. Secondly we're protected 2948 2948 * against a concurrent mm_take_all_locks() by the mm_all_locks_mutex. 2949 2949 *