Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

clk: hsdk-pll: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20230312161512.2715500-12-u.kleine-koenig@pengutronix.de
Signed-off-by: Stephen Boyd <sboyd@kernel.org>

authored by

Uwe Kleine-König and committed by
Stephen Boyd
601b2f14 57e20d68

+2 -3
+2 -3
drivers/clk/clk-hsdk-pll.c
··· 350 350 &pll_clk->hw); 351 351 } 352 352 353 - static int hsdk_pll_clk_remove(struct platform_device *pdev) 353 + static void hsdk_pll_clk_remove(struct platform_device *pdev) 354 354 { 355 355 of_clk_del_provider(pdev->dev.of_node); 356 - return 0; 357 356 } 358 357 359 358 static void __init of_hsdk_pll_clk_setup(struct device_node *node) ··· 431 432 .of_match_table = hsdk_pll_clk_id, 432 433 }, 433 434 .probe = hsdk_pll_clk_probe, 434 - .remove = hsdk_pll_clk_remove, 435 + .remove_new = hsdk_pll_clk_remove, 435 436 }; 436 437 builtin_platform_driver(hsdk_pll_clk_driver);