Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

phy: renesas: phy-rcar-gen3-usb3: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Link: https://lore.kernel.org/r/20230307115900.2293120-18-u.kleine-koenig@pengutronix.de
Signed-off-by: Vinod Koul <vkoul@kernel.org>

authored by

Uwe Kleine-König and committed by
Vinod Koul
8e593a22 c7ac6dff

+2 -4
+2 -4
drivers/phy/renesas/phy-rcar-gen3-usb3.c
··· 199 199 return ret; 200 200 } 201 201 202 - static int rcar_gen3_phy_usb3_remove(struct platform_device *pdev) 202 + static void rcar_gen3_phy_usb3_remove(struct platform_device *pdev) 203 203 { 204 204 pm_runtime_disable(&pdev->dev); 205 - 206 - return 0; 207 205 }; 208 206 209 207 static struct platform_driver rcar_gen3_phy_usb3_driver = { ··· 210 212 .of_match_table = rcar_gen3_phy_usb3_match_table, 211 213 }, 212 214 .probe = rcar_gen3_phy_usb3_probe, 213 - .remove = rcar_gen3_phy_usb3_remove, 215 + .remove_new = rcar_gen3_phy_usb3_remove, 214 216 }; 215 217 module_platform_driver(rcar_gen3_phy_usb3_driver); 216 218