Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

phy: renesas: phy-rcar-gen3-usb2: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Link: https://lore.kernel.org/r/20230307115900.2293120-17-u.kleine-koenig@pengutronix.de
Signed-off-by: Vinod Koul <vkoul@kernel.org>

authored by

Uwe Kleine-König and committed by
Vinod Koul
c7ac6dff aba5c6f3

+2 -4
+2 -4
drivers/phy/renesas/phy-rcar-gen3-usb2.c
··· 755 755 return ret; 756 756 } 757 757 758 - static int rcar_gen3_phy_usb2_remove(struct platform_device *pdev) 758 + static void rcar_gen3_phy_usb2_remove(struct platform_device *pdev) 759 759 { 760 760 struct rcar_gen3_chan *channel = platform_get_drvdata(pdev); 761 761 ··· 763 763 device_remove_file(&pdev->dev, &dev_attr_role); 764 764 765 765 pm_runtime_disable(&pdev->dev); 766 - 767 - return 0; 768 766 }; 769 767 770 768 static struct platform_driver rcar_gen3_phy_usb2_driver = { ··· 771 773 .of_match_table = rcar_gen3_phy_usb2_match_table, 772 774 }, 773 775 .probe = rcar_gen3_phy_usb2_probe, 774 - .remove = rcar_gen3_phy_usb2_remove, 776 + .remove_new = rcar_gen3_phy_usb2_remove, 775 777 }; 776 778 module_platform_driver(rcar_gen3_phy_usb2_driver); 777 779