Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

iio: light: cm36651: Make use of the helper function dev_err_probe()

When possible use dev_err_probe help to properly deal with the
PROBE_DEFER error, the benefit is that DEFER issue will be logged
in the devices_deferred debugfs file.
Using dev_err_probe() can reduce code size, and the error value
gets printed.

Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
Link: https://lore.kernel.org/r/20210928014156.1491-2-caihuoqing@baidu.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

authored by

Cai Huoqing and committed by
Jonathan Cameron
8283b954 842f221d

+3 -4
+3 -4
drivers/iio/light/cm36651.c
··· 632 632 cm36651 = iio_priv(indio_dev); 633 633 634 634 cm36651->vled_reg = devm_regulator_get(&client->dev, "vled"); 635 - if (IS_ERR(cm36651->vled_reg)) { 636 - dev_err(&client->dev, "get regulator vled failed\n"); 637 - return PTR_ERR(cm36651->vled_reg); 638 - } 635 + if (IS_ERR(cm36651->vled_reg)) 636 + return dev_err_probe(&client->dev, PTR_ERR(cm36651->vled_reg), 637 + "get regulator vled failed\n"); 639 638 640 639 ret = regulator_enable(cm36651->vled_reg); 641 640 if (ret) {