Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

iio: health: afe4404: Make use of the helper function dev_err_probe()

When possible use dev_err_probe help to properly deal with the
PROBE_DEFER error, the benefit is that DEFER issue will be logged
in the devices_deferred debugfs file.
Using dev_err_probe() can reduce code size, and the error value
gets printed.

Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
Link: https://lore.kernel.org/r/20210928014403.1563-2-caihuoqing@baidu.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

authored by

Cai Huoqing and committed by
Jonathan Cameron
842f221d 8025ea50

+4 -4
+4 -4
drivers/iio/health/afe4404.c
··· 494 494 } 495 495 496 496 afe->regulator = devm_regulator_get(afe->dev, "tx_sup"); 497 - if (IS_ERR(afe->regulator)) { 498 - dev_err(afe->dev, "Unable to get regulator\n"); 499 - return PTR_ERR(afe->regulator); 500 - } 497 + if (IS_ERR(afe->regulator)) 498 + return dev_err_probe(afe->dev, PTR_ERR(afe->regulator), 499 + "Unable to get regulator\n"); 500 + 501 501 ret = regulator_enable(afe->regulator); 502 502 if (ret) { 503 503 dev_err(afe->dev, "Unable to enable regulator\n");