Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

misc: genwqe: card_dev: Whole host of kerneldoc fixes

Including; add missing documentation for function arguments, re-ordering
of #defines i.e. not placed between kerneldoc headers and the functions
they are documenting, demotion of file header/comment from kerneldoc
format and removal of documentation for non-existent args.

Fixes the following W=1 kernel build warnings:

drivers/misc/genwqe/card_dev.c:33: warning: Function parameter or member 'cd' not described in 'genwqe_open_files'
drivers/misc/genwqe/card_dev.c:98: warning: Function parameter or member 'virt_addr' not described in 'genwqe_search_pin'
drivers/misc/genwqe/card_dev.c:98: warning: Excess function parameter 'dma_addr' description in 'genwqe_search_pin'
drivers/misc/genwqe/card_dev.c:154: warning: Function parameter or member 'virt_addr' not described in '__genwqe_search_mapping'
drivers/misc/genwqe/card_dev.c:256: warning: Function parameter or member 'cd' not described in 'genwqe_kill_fasync'
drivers/misc/genwqe/card_dev.c:256: warning: Function parameter or member 'sig' not described in 'genwqe_kill_fasync'
drivers/misc/genwqe/card_dev.c:387: warning: Function parameter or member 'vma' not described in 'genwqe_vma_close'
drivers/misc/genwqe/card_dev.c:430: warning: Function parameter or member 'filp' not described in 'genwqe_mmap'
drivers/misc/genwqe/card_dev.c:430: warning: Function parameter or member 'vma' not described in 'genwqe_mmap'
drivers/misc/genwqe/card_dev.c:495: warning: Excess function parameter 'cd' description in 'FLASH_BLOCK'
drivers/misc/genwqe/card_dev.c:495: warning: Excess function parameter 'load' description in 'FLASH_BLOCK'
drivers/misc/genwqe/card_dev.c:827: warning: Function parameter or member 'cfile' not described in 'ddcb_cmd_cleanup'
drivers/misc/genwqe/card_dev.c:827: warning: Function parameter or member 'req' not described in 'ddcb_cmd_cleanup'
drivers/misc/genwqe/card_dev.c:854: warning: Function parameter or member 'cfile' not described in 'ddcb_cmd_fixups'
drivers/misc/genwqe/card_dev.c:854: warning: Function parameter or member 'req' not described in 'ddcb_cmd_fixups'
drivers/misc/genwqe/card_dev.c:984: warning: Function parameter or member 'cfile' not described in 'genwqe_execute_ddcb'
drivers/misc/genwqe/card_dev.c:984: warning: Function parameter or member 'cmd' not described in 'genwqe_execute_ddcb'
drivers/misc/genwqe/card_dev.c:1350: warning: Function parameter or member 'cd' not described in 'genwqe_device_remove'

Cc: Michael Jung <mijung@gmx.net>
Cc: Michael Ruettger <michael@ibmra.de>
Cc: Frank Haverkamp <haver@linux.ibm.com>
Cc: Joerg-Stephan Vogt <jsvogt@de.ibm.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Reviewed-by: Frank Haverkamp <haver@linux.ibm.com>
Link: https://lore.kernel.org/r/20200701085853.164358-20-lee.jones@linaro.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

authored by

Lee Jones and committed by
Greg Kroah-Hartman
807062fc a562c0c3

+18 -6
+18 -6
drivers/misc/genwqe/card_dev.c
··· 1 1 // SPDX-License-Identifier: GPL-2.0-only 2 - /** 2 + /* 3 3 * IBM Accelerator Family 'GenWQE' 4 4 * 5 5 * (C) Copyright IBM Corp. 2013 ··· 87 87 * @cfile: Descriptor of opened file 88 88 * @u_addr: User virtual address 89 89 * @size: Size of buffer 90 - * @dma_addr: DMA address to be updated 90 + * @virt_addr: Virtual address to be updated 91 91 * 92 92 * Return: Pointer to the corresponding mapping NULL if not found 93 93 */ ··· 144 144 * @u_addr: user virtual address 145 145 * @size: size of buffer 146 146 * @dma_addr: DMA address to be updated 147 + * @virt_addr: Virtual address to be updated 147 148 * Return: Pointer to the corresponding mapping NULL if not found 148 149 */ 149 150 static struct dma_mapping *__genwqe_search_mapping(struct genwqe_file *cfile, ··· 250 249 251 250 /** 252 251 * genwqe_kill_fasync() - Send signal to all processes with open GenWQE files 252 + * @cd: GenWQE device information 253 + * @sig: Signal to send out 253 254 * 254 255 * E.g. genwqe_send_signal(cd, SIGIO); 255 256 */ ··· 383 380 384 381 /** 385 382 * genwqe_vma_close() - Called each time when vma is unmapped 383 + * @vma: VMA area to close 386 384 * 387 385 * Free memory which got allocated by GenWQE mmap(). 388 386 */ ··· 420 416 421 417 /** 422 418 * genwqe_mmap() - Provide contignous buffers to userspace 419 + * @filp: File pointer (unused) 420 + * @vma: VMA area to map 423 421 * 424 422 * We use mmap() to allocate contignous buffers used for DMA 425 423 * transfers. After the buffer is allocated we remap it to user-space ··· 490 484 return rc; 491 485 } 492 486 487 + #define FLASH_BLOCK 0x40000 /* we use 256k blocks */ 488 + 493 489 /** 494 490 * do_flash_update() - Excute flash update (write image or CVPD) 495 - * @cd: genwqe device 491 + * @cfile: Descriptor of opened file 496 492 * @load: details about image load 497 493 * 498 494 * Return: 0 if successful 499 495 */ 500 - 501 - #define FLASH_BLOCK 0x40000 /* we use 256k blocks */ 502 - 503 496 static int do_flash_update(struct genwqe_file *cfile, 504 497 struct genwqe_bitstream *load) 505 498 { ··· 825 820 826 821 /** 827 822 * ddcb_cmd_cleanup() - Remove dynamically created fixup entries 823 + * @cfile: Descriptor of opened file 824 + * @req: DDCB work request 828 825 * 829 826 * Only if there are any. Pinnings are not removed. 830 827 */ ··· 851 844 852 845 /** 853 846 * ddcb_cmd_fixups() - Establish DMA fixups/sglists for user memory references 847 + * @cfile: Descriptor of opened file 848 + * @req: DDCB work request 854 849 * 855 850 * Before the DDCB gets executed we need to handle the fixups. We 856 851 * replace the user-space addresses with DMA addresses or do ··· 983 974 984 975 /** 985 976 * genwqe_execute_ddcb() - Execute DDCB using userspace address fixups 977 + * @cfile: Descriptor of opened file 978 + * @cmd: Command identifier (passed from user) 986 979 * 987 980 * The code will build up the translation tables or lookup the 988 981 * contignous memory allocation table to find the right translations ··· 1350 1339 1351 1340 /** 1352 1341 * genwqe_device_remove() - Remove genwqe's char device 1342 + * @cd: GenWQE device information 1353 1343 * 1354 1344 * This function must be called after the client devices are removed 1355 1345 * because it will free the major/minor number range for the genwqe