Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

misc: genwqe: card_base: Whole host of kerneldoc fixes

>From missing documentation for function arguments, to promotion
obvious kerneldoc headers and incorrectly named arguments.

Fixes the following W=1 warnings:

drivers/misc/genwqe/card_base.c:175: warning: Function parameter or member 'cd' not described in 'genwqe_bus_reset'
drivers/misc/genwqe/card_base.c:272: warning: Function parameter or member 'cd' not described in 'genwqe_recovery_on_fatal_gfir_required'
drivers/misc/genwqe/card_base.c:293: warning: Function parameter or member 'cd' not described in 'genwqe_T_psec'
drivers/misc/genwqe/card_base.c:314: warning: Function parameter or member 'cd' not described in 'genwqe_setup_pf_jtimer'
drivers/misc/genwqe/card_base.c:334: warning: Function parameter or member 'cd' not described in 'genwqe_setup_vf_jtimer'
drivers/misc/genwqe/card_base.c:557: warning: Function parameter or member 'cd' not described in 'genwqe_stop'
drivers/misc/genwqe/card_base.c:617: warning: Function parameter or member 'cd' not described in 'genwqe_fir_checking'
drivers/misc/genwqe/card_base.c:760: warning: Function parameter or member 'pci_dev' not described in 'genwqe_pci_fundamental_reset'
drivers/misc/genwqe/card_base.c:889: warning: Function parameter or member 'data' not described in 'genwqe_health_thread'
drivers/misc/genwqe/card_base.c:1046: warning: Function parameter or member 'cd' not described in 'genwqe_pci_setup'
drivers/misc/genwqe/card_base.c:1131: warning: Function parameter or member 'cd' not described in 'genwqe_pci_remove'
drivers/misc/genwqe/card_base.c:1151: warning: Function parameter or member 'pci_dev' not described in 'genwqe_probe'
drivers/misc/genwqe/card_base.c:1151: warning: Function parameter or member 'id' not described in 'genwqe_probe'
drivers/misc/genwqe/card_base.c:1151: warning: Excess function parameter 'pdev' description in 'genwqe_probe'
drivers/misc/genwqe/card_base.c:1207: warning: Function parameter or member 'pci_dev' not described in 'genwqe_remove'
drivers/misc/genwqe/card_base.c:1336: warning: Function parameter or member 'dev' not described in 'genwqe_devnode'
drivers/misc/genwqe/card_base.c:1336: warning: Function parameter or member 'mode' not described in 'genwqe_devnode'

Cc: Michael Jung <mijung@gmx.net>
Cc: Michael Ruettger <michael@ibmra.de>
Cc: Frank Haverkamp <haver@linux.ibm.com>
Cc: Joerg-Stephan Vogt <jsvogt@de.ibm.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Reviewed-by: Frank Haverkamp <haver@linux.ibm.com>
Link: https://lore.kernel.org/r/20200701085853.164358-19-lee.jones@linaro.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

authored by

Lee Jones and committed by
Greg Kroah-Hartman
a562c0c3 f5721c7a

+21 -3
+21 -3
drivers/misc/genwqe/card_base.c
··· 165 165 166 166 /** 167 167 * genwqe_bus_reset() - Card recovery 168 + * @cd: GenWQE device information 168 169 * 169 170 * pci_reset_function() will recover the device and ensure that the 170 171 * registers are accessible again when it completes with success. If ··· 263 262 264 263 /** 265 264 * genwqe_recovery_on_fatal_gfir_required() - Version depended actions 265 + * @cd: GenWQE device information 266 266 * 267 267 * Bitstreams older than 2013-02-17 have a bug where fatal GFIRs must 268 268 * be ignored. This is e.g. true for the bitstream we gave to the card ··· 282 280 283 281 /** 284 282 * genwqe_T_psec() - Calculate PF/VF timeout register content 283 + * @cd: GenWQE device information 285 284 * 286 285 * Note: From a design perspective it turned out to be a bad idea to 287 286 * use codes here to specifiy the frequency/speed values. An old ··· 306 303 307 304 /** 308 305 * genwqe_setup_pf_jtimer() - Setup PF hardware timeouts for DDCB execution 306 + * @cd: GenWQE device information 309 307 * 310 308 * Do this _after_ card_reset() is called. Otherwise the values will 311 309 * vanish. The settings need to be done when the queues are inactive. ··· 333 329 334 330 /** 335 331 * genwqe_setup_vf_jtimer() - Setup VF hardware timeouts for DDCB execution 332 + * @cd: GenWQE device information 336 333 */ 337 334 static bool genwqe_setup_vf_jtimer(struct genwqe_dev *cd) 338 335 { ··· 548 543 549 544 /** 550 545 * genwqe_stop() - Stop card operation 546 + * @cd: GenWQE device information 551 547 * 552 548 * Recovery notes: 553 549 * As long as genwqe_thread runs we might access registers during ··· 626 620 627 621 /** 628 622 * genwqe_fir_checking() - Check the fault isolation registers of the card 623 + * @cd: GenWQE device information 629 624 * 630 625 * If this code works ok, can be tried out with help of the genwqe_poke tool: 631 626 * sudo ./tools/genwqe_poke 0x8 0xfefefefefef ··· 771 764 772 765 /** 773 766 * genwqe_pci_fundamental_reset() - trigger a PCIe fundamental reset on the slot 767 + * @pci_dev: PCI device information struct 774 768 * 775 769 * Note: pci_set_pcie_reset_state() is not implemented on all archs, so this 776 770 * reset method will not work in all cases. ··· 836 828 return rc; 837 829 } 838 830 839 - /* 831 + /** 840 832 * genwqe_reload_bistream() - reload card bitstream 833 + * @cd: GenWQE device information 841 834 * 842 835 * Set the appropriate register and call fundamental reset to reaload the card 843 836 * bitstream. ··· 891 882 892 883 /** 893 884 * genwqe_health_thread() - Health checking thread 885 + * @data: GenWQE device information 894 886 * 895 887 * This thread is only started for the PF of the card. 896 888 * ··· 1065 1055 1066 1056 /** 1067 1057 * genwqe_pci_setup() - Allocate PCIe related resources for our card 1058 + * @cd: GenWQE device information 1068 1059 */ 1069 1060 static int genwqe_pci_setup(struct genwqe_dev *cd) 1070 1061 { ··· 1151 1140 1152 1141 /** 1153 1142 * genwqe_pci_remove() - Free PCIe related resources for our card 1143 + * @cd: GenWQE device information 1154 1144 */ 1155 1145 static void genwqe_pci_remove(struct genwqe_dev *cd) 1156 1146 { ··· 1166 1154 1167 1155 /** 1168 1156 * genwqe_probe() - Device initialization 1169 - * @pdev: PCI device information struct 1157 + * @pci_dev: PCI device information struct 1158 + * @id: PCI device ID 1170 1159 * 1171 1160 * Callable for multiple cards. This function is called on bind. 1172 1161 * ··· 1227 1214 1228 1215 /** 1229 1216 * genwqe_remove() - Called when device is removed (hot-plugable) 1217 + * @pci_dev: PCI device information struct 1230 1218 * 1231 1219 * Or when driver is unloaded respecitively when unbind is done. 1232 1220 */ ··· 1247 1233 genwqe_dev_free(cd); 1248 1234 } 1249 1235 1250 - /* 1236 + /** 1251 1237 * genwqe_err_error_detected() - Error detection callback 1238 + * @pci_dev: PCI device information struct 1239 + * @state: PCI channel state 1252 1240 * 1253 1241 * This callback is called by the PCI subsystem whenever a PCI bus 1254 1242 * error is detected. ··· 1358 1342 1359 1343 /** 1360 1344 * genwqe_devnode() - Set default access mode for genwqe devices. 1345 + * @dev: Pointer to device (unused) 1346 + * @mode: Carrier to pass-back given mode (permissions) 1361 1347 * 1362 1348 * Default mode should be rw for everybody. Do not change default 1363 1349 * device name.