Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

firmware: qcom: scm: Fix error code in probe()

Set the error code if devm_qcom_tzmem_pool_new() fails. Don't return
success.

Fixes: 1e76b546e6fc ("firmware: qcom: scm: Cleanup global '__scm' on probe failures")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Link: https://lore.kernel.org/r/a0845467-4f83-4070-ab1e-ff7e6764609f@stanley.mountain
Signed-off-by: Bjorn Andersson <andersson@kernel.org>

authored by

Dan Carpenter and committed by
Bjorn Andersson
7f048b20 1ac98d64

+2 -2
+2 -2
drivers/firmware/qcom/qcom_scm.c
··· 2301 2301 2302 2302 __scm->mempool = devm_qcom_tzmem_pool_new(__scm->dev, &pool_config); 2303 2303 if (IS_ERR(__scm->mempool)) { 2304 - dev_err_probe(__scm->dev, PTR_ERR(__scm->mempool), 2305 - "Failed to create the SCM memory pool\n"); 2304 + ret = dev_err_probe(__scm->dev, PTR_ERR(__scm->mempool), 2305 + "Failed to create the SCM memory pool\n"); 2306 2306 goto err; 2307 2307 } 2308 2308