Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

soc: qcom: pmic_glink: Drop redundant pg assignment before taking lock

Commit e9f826b0459f ("soc: qcom: pmic_glink: simplify locking with
guard()") was on top of a fix [1] which was moving the 'pg =
__pmic_glink' assignment into the critical section. Unfortunately the
actual fix was not applied and instead rebased version of the next patch
got in. The resulting code is in general correct, but now there is a
duplicated assignment 'pg = __pmic_glink'.

[1] https://lore.kernel.org/all/20240822164815.230167-1-krzysztof.kozlowski@linaro.org/

Fixes: e9f826b0459f ("soc: qcom: pmic_glink: simplify locking with guard()")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Link: https://lore.kernel.org/r/20250111172326.101779-1-krzysztof.kozlowski@linaro.org
Signed-off-by: Bjorn Andersson <andersson@kernel.org>

authored by

Krzysztof Kozlowski and committed by
Bjorn Andersson
1ac98d64 2014c95a

+1 -1
+1 -1
drivers/soc/qcom/pmic_glink.c
··· 233 233 234 234 static int pmic_glink_rpmsg_probe(struct rpmsg_device *rpdev) 235 235 { 236 - struct pmic_glink *pg = __pmic_glink; 236 + struct pmic_glink *pg; 237 237 238 238 guard(mutex)(&__pmic_glink_lock); 239 239 pg = __pmic_glink;