Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

power: supply: da9150-charger: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new() which already returns void. Eventually after all drivers
are converted, .remove_new() is renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20230918133700.1254499-13-u.kleine-koenig@pengutronix.de
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>

authored by

Uwe Kleine-König and committed by
Sebastian Reichel
749e18a8 ac67d7fd

+2 -4
+2 -4
drivers/power/supply/da9150-charger.c
··· 635 635 return ret; 636 636 } 637 637 638 - static int da9150_charger_remove(struct platform_device *pdev) 638 + static void da9150_charger_remove(struct platform_device *pdev) 639 639 { 640 640 struct da9150_charger *charger = platform_get_drvdata(pdev); 641 641 int irq; ··· 665 665 iio_channel_release(charger->vbus_chan); 666 666 iio_channel_release(charger->tjunc_chan); 667 667 iio_channel_release(charger->vbat_chan); 668 - 669 - return 0; 670 668 } 671 669 672 670 static struct platform_driver da9150_charger_driver = { ··· 672 674 .name = "da9150-charger", 673 675 }, 674 676 .probe = da9150_charger_probe, 675 - .remove = da9150_charger_remove, 677 + .remove_new = da9150_charger_remove, 676 678 }; 677 679 678 680 module_platform_driver(da9150_charger_driver);