Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

power: supply: da9052-battery: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new() which already returns void. Eventually after all drivers
are converted, .remove_new() is renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20230918133700.1254499-12-u.kleine-koenig@pengutronix.de
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>

authored by

Uwe Kleine-König and committed by
Sebastian Reichel
ac67d7fd b5ba26ab

+2 -4
+2 -4
drivers/power/supply/da9052-battery.c
··· 637 637 638 638 return ret; 639 639 } 640 - static int da9052_bat_remove(struct platform_device *pdev) 640 + static void da9052_bat_remove(struct platform_device *pdev) 641 641 { 642 642 int i; 643 643 struct da9052_battery *bat = platform_get_drvdata(pdev); ··· 646 646 da9052_free_irq(bat->da9052, da9052_bat_irq_bits[i], bat); 647 647 648 648 power_supply_unregister(bat->psy); 649 - 650 - return 0; 651 649 } 652 650 653 651 static struct platform_driver da9052_bat_driver = { 654 652 .probe = da9052_bat_probe, 655 - .remove = da9052_bat_remove, 653 + .remove_new = da9052_bat_remove, 656 654 .driver = { 657 655 .name = "da9052-bat", 658 656 },