Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drm/panel: ilitek-ili9882t: Check for errors on the NOP in prepare()

The mipi_dsi_dcs_nop() function returns an error but we weren't
checking it in ili9882t_prepare(). Add a check. This is highly
unlikely to matter in practice. If the NOP failed then likely later
MIPI commands would fail too.

Found by code inspection.

Fixes: e2450d32e5fb ("drm/panel: ili9882t: Break out as separate driver")
Signed-off-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Link: https://lore.kernel.org/r/20240517143643.5.I323476ba9fa8cc7a5adee4c1ec95202785cc5686@changeid
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20240517143643.5.I323476ba9fa8cc7a5adee4c1ec95202785cc5686@changeid

authored by

Douglas Anderson and committed by
Neil Armstrong
6a7bd6cd 554c0018

+5 -1
+5 -1
drivers/gpu/drm/panel/panel-ilitek-ili9882t.c
··· 478 478 usleep_range(10000, 11000); 479 479 480 480 // MIPI needs to keep the LP11 state before the lcm_reset pin is pulled high 481 - mipi_dsi_dcs_nop(ili->dsi); 481 + ret = mipi_dsi_dcs_nop(ili->dsi); 482 + if (ret < 0) { 483 + dev_err(&ili->dsi->dev, "Failed to send NOP: %d\n", ret); 484 + goto poweroff; 485 + } 482 486 usleep_range(1000, 2000); 483 487 484 488 gpiod_set_value(ili->enable_gpio, 1);