Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drm/panel: ilitek-ili9882t: If prepare fails, disable GPIO before regulators

The enable GPIO should clearly be set low before turning off
regulators. That matches both the inverse order that things were
enabled and also the order in unprepare().

Fixes: e2450d32e5fb ("drm/panel: ili9882t: Break out as separate driver")
Signed-off-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Link: https://lore.kernel.org/r/20240517143643.4.Ieb0179065847972a0f13e9a8574a80a5f65f3338@changeid
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20240517143643.4.Ieb0179065847972a0f13e9a8574a80a5f65f3338@changeid

authored by

Douglas Anderson and committed by
Neil Armstrong
554c0018 6320b919

+1 -1
+1 -1
drivers/gpu/drm/panel/panel-ilitek-ili9882t.c
··· 495 495 return 0; 496 496 497 497 poweroff: 498 + gpiod_set_value(ili->enable_gpio, 0); 498 499 regulator_disable(ili->avee); 499 500 poweroffavdd: 500 501 regulator_disable(ili->avdd); 501 502 poweroff1v8: 502 503 usleep_range(5000, 7000); 503 504 regulator_disable(ili->pp1800); 504 - gpiod_set_value(ili->enable_gpio, 0); 505 505 506 506 return ret; 507 507 }