Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

leds: lp5523: check return value of lp5xx_read and jump to cleanup code

Check return value of lp5xx_read and if non-zero, jump to code at end of
the function, causing lp5523_stop_all_engines to be executed before
returning the error value up the call chain. This fixes the original
commit (248b57015f35) which was reverted due to the University of Minnesota
problems.

Cc: stable <stable@vger.kernel.org>
Acked-by: Jacek Anaszewski <jacek.anaszewski@gmail.com>
Signed-off-by: Phillip Potter <phil@philpotter.co.uk>
Link: https://lore.kernel.org/r/20210503115736.2104747-10-gregkh@linuxfoundation.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

authored by

Phillip Potter and committed by
Greg Kroah-Hartman
6647f7a0 8d1beda5

+3 -1
+3 -1
drivers/leds/leds-lp5523.c
··· 305 305 306 306 /* Let the programs run for couple of ms and check the engine status */ 307 307 usleep_range(3000, 6000); 308 - lp55xx_read(chip, LP5523_REG_STATUS, &status); 308 + ret = lp55xx_read(chip, LP5523_REG_STATUS, &status); 309 + if (ret) 310 + goto out; 309 311 status &= LP5523_ENG_STATUS_MASK; 310 312 311 313 if (status != LP5523_ENG_STATUS_MASK) {