Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

Revert "leds: lp5523: fix a missing check of return value of lp55xx_read"

This reverts commit 248b57015f35c94d4eae2fdd8c6febf5cd703900.

Because of recent interactions with developers from @umn.edu, all
commits from them have been recently re-reviewed to ensure if they were
correct or not.

Upon review, this commit was found to be incorrect for the reasons
below, so it must be reverted. It will be fixed up "correctly" in a
later kernel change.

The original commit does not properly unwind if there is an error
condition so it needs to be reverted at this point in time.

Cc: Kangjie Lu <kjlu@umn.edu>
Cc: Jacek Anaszewski <jacek.anaszewski@gmail.com>
Cc: stable <stable@vger.kernel.org>
Fixes: 248b57015f35 ("leds: lp5523: fix a missing check of return value of lp55xx_read")
Link: https://lore.kernel.org/r/20210503115736.2104747-9-gregkh@linuxfoundation.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

+1 -3
+1 -3
drivers/leds/leds-lp5523.c
··· 305 305 306 306 /* Let the programs run for couple of ms and check the engine status */ 307 307 usleep_range(3000, 6000); 308 - ret = lp55xx_read(chip, LP5523_REG_STATUS, &status); 309 - if (ret) 310 - return ret; 308 + lp55xx_read(chip, LP5523_REG_STATUS, &status); 311 309 status &= LP5523_ENG_STATUS_MASK; 312 310 313 311 if (status != LP5523_ENG_STATUS_MASK) {