Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

media: platform: mtk-mdp3: Remove mask parameter from MM_REG_POLL macro

Just like was done with MM_REG_WRITE, remove the mask from the
MM_REG_POLL macro, leaving MM_REG_POLL_MASK to be used when a mask is
required, and update the call sites accordingly. In this case, all calls
require a mask, so MM_REG_POLL remains unused, but at least this makes
the MM_REG_POLL macros consistent with the MM_REG_WRITE ones.

Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Signed-off-by: Sebastian Fricke <sebastian.fricke@collabora.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>

authored by

Nícolas F. R. A. Prado and committed by
Mauro Carvalho Chehab
6633de33 7b00fcfd

+9 -12
+4 -4
drivers/media/platform/mediatek/mdp3/mtk-mdp3-comp.c
··· 78 78 79 79 /* Reset RDMA */ 80 80 MM_REG_WRITE_MASK(cmd, subsys_id, base, MDP_RDMA_RESET, BIT(0), BIT(0)); 81 - MM_REG_POLL(cmd, subsys_id, base, MDP_RDMA_MON_STA_1, BIT(8), BIT(8)); 81 + MM_REG_POLL_MASK(cmd, subsys_id, base, MDP_RDMA_MON_STA_1, BIT(8), BIT(8)); 82 82 MM_REG_WRITE_MASK(cmd, subsys_id, base, MDP_RDMA_RESET, 0x0, BIT(0)); 83 83 return 0; 84 84 } ··· 634 634 635 635 /* Reset WROT */ 636 636 MM_REG_WRITE_MASK(cmd, subsys_id, base, VIDO_SOFT_RST, BIT(0), BIT(0)); 637 - MM_REG_POLL(cmd, subsys_id, base, VIDO_SOFT_RST_STAT, BIT(0), BIT(0)); 637 + MM_REG_POLL_MASK(cmd, subsys_id, base, VIDO_SOFT_RST_STAT, BIT(0), BIT(0)); 638 638 639 639 /* Reset setting */ 640 640 if (CFG_CHECK(MT8195, p_id)) 641 641 MM_REG_WRITE(cmd, subsys_id, base, VIDO_CTRL, 0x0); 642 642 643 643 MM_REG_WRITE_MASK(cmd, subsys_id, base, VIDO_SOFT_RST, 0x0, BIT(0)); 644 - MM_REG_POLL(cmd, subsys_id, base, VIDO_SOFT_RST_STAT, 0x0, BIT(0)); 644 + MM_REG_POLL_MASK(cmd, subsys_id, base, VIDO_SOFT_RST_STAT, 0x0, BIT(0)); 645 645 return 0; 646 646 } 647 647 ··· 871 871 872 872 /* Reset WDMA */ 873 873 MM_REG_WRITE_MASK(cmd, subsys_id, base, WDMA_RST, BIT(0), BIT(0)); 874 - MM_REG_POLL(cmd, subsys_id, base, WDMA_FLOW_CTRL_DBG, BIT(0), BIT(0)); 874 + MM_REG_POLL_MASK(cmd, subsys_id, base, WDMA_FLOW_CTRL_DBG, BIT(0), BIT(0)); 875 875 MM_REG_WRITE_MASK(cmd, subsys_id, base, WDMA_RST, 0x0, BIT(0)); 876 876 return 0; 877 877 }
+5 -8
drivers/media/platform/mediatek/mdp3/mtk-mdp3-comp.h
··· 53 53 do { \ 54 54 typeof(_mask) (_m) = (_mask); \ 55 55 cmdq_pkt_poll_mask(&((cmd)->pkt), id, \ 56 - (base) + (ofst), (val), (_m)); \ 56 + (base) + (ofst), (val), \ 57 + (((_m) & (ofst##_MASK)) == (ofst##_MASK)) ? \ 58 + (0xffffffff) : (_m)); \ 57 59 } while (0) 58 60 59 - #define MM_REG_POLL(cmd, id, base, ofst, val, mask) \ 60 - do { \ 61 - typeof(mask) (m) = (mask); \ 62 - MM_REG_POLL_MASK((cmd), id, base, ofst, val, \ 63 - (((m) & (ofst##_MASK)) == (ofst##_MASK)) ? \ 64 - (0xffffffff) : (m)); \ 65 - } while (0) 61 + #define MM_REG_POLL(cmd, id, base, ofst, val) \ 62 + cmdq_pkt_poll(&((cmd)->pkt), id, (base) + (ofst), (val)) 66 63 67 64 enum mtk_mdp_comp_id { 68 65 MDP_COMP_NONE = -1, /* Invalid engine */