Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

phy: qualcomm: phy-qcom-apq8064-sata: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20230307115900.2293120-13-u.kleine-koenig@pengutronix.de
Signed-off-by: Vinod Koul <vkoul@kernel.org>

authored by

Uwe Kleine-König and committed by
Vinod Koul
64299241 cbed624f

+2 -4
+2 -4
drivers/phy/qualcomm/phy-qcom-apq8064-sata.c
··· 243 243 return 0; 244 244 } 245 245 246 - static int qcom_apq8064_sata_phy_remove(struct platform_device *pdev) 246 + static void qcom_apq8064_sata_phy_remove(struct platform_device *pdev) 247 247 { 248 248 struct qcom_apq8064_sata_phy *phy = platform_get_drvdata(pdev); 249 249 250 250 clk_disable_unprepare(phy->cfg_clk); 251 - 252 - return 0; 253 251 } 254 252 255 253 static const struct of_device_id qcom_apq8064_sata_phy_of_match[] = { ··· 258 260 259 261 static struct platform_driver qcom_apq8064_sata_phy_driver = { 260 262 .probe = qcom_apq8064_sata_phy_probe, 261 - .remove = qcom_apq8064_sata_phy_remove, 263 + .remove_new = qcom_apq8064_sata_phy_remove, 262 264 .driver = { 263 265 .name = "qcom-apq8064-sata-phy", 264 266 .of_match_table = qcom_apq8064_sata_phy_of_match,