Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

phy: phy-lgm-usb: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20230307115900.2293120-12-u.kleine-koenig@pengutronix.de
Signed-off-by: Vinod Koul <vkoul@kernel.org>

authored by

Uwe Kleine-König and committed by
Vinod Koul
cbed624f 91537c86

+2 -4
+2 -4
drivers/phy/phy-lgm-usb.c
··· 252 252 return usb_add_phy_dev(phy); 253 253 } 254 254 255 - static int phy_remove(struct platform_device *pdev) 255 + static void phy_remove(struct platform_device *pdev) 256 256 { 257 257 struct tca_apb *ta = platform_get_drvdata(pdev); 258 258 259 259 usb_remove_phy(&ta->phy); 260 - 261 - return 0; 262 260 } 263 261 264 262 static const struct of_device_id intel_usb_phy_dt_ids[] = { ··· 271 273 .of_match_table = intel_usb_phy_dt_ids, 272 274 }, 273 275 .probe = phy_probe, 274 - .remove = phy_remove, 276 + .remove_new = phy_remove, 275 277 }; 276 278 277 279 module_platform_driver(lgm_phy_driver);