Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

fbdev: Remove FBINFO_DEFAULT from static structs

The flag FBINFO_DEFAULT is 0 and has no effect, as struct fbinfo.flags
has been allocated to zero by a static declaration. So do not set it.

Flags should signal differences from the default values. After cleaning
up all occurrences of FBINFO_DEFAULT, the token will be removed.

v4:
* clarify commit message (Geert, Dan)
v2:
* fix commit message (Miguel)

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Acked-by: Sam Ravnborg <sam@ravnborg.org>
Cc: Helge Deller <deller@gmx.de>
Link: https://patchwork.freedesktop.org/patch/msgid/20230715185343.7193-3-tzimmermann@suse.de

+3 -6
+1 -1
drivers/video/fbdev/68328fb.c
··· 448 448 fb_info.var.red.offset = fb_info.var.green.offset = fb_info.var.blue.offset = 0; 449 449 } 450 450 fb_info.pseudo_palette = &mc68x328fb_pseudo_palette; 451 - fb_info.flags = FBINFO_DEFAULT | FBINFO_HWACCEL_YPAN; 451 + fb_info.flags = FBINFO_HWACCEL_YPAN; 452 452 453 453 if (fb_alloc_cmap(&fb_info.cmap, 256, 0)) 454 454 return -ENOMEM;
+1 -1
drivers/video/fbdev/acornfb.c
··· 694 694 first = 0; 695 695 696 696 fb_info.fbops = &acornfb_ops; 697 - fb_info.flags = FBINFO_DEFAULT | FBINFO_HWACCEL_YPAN; 697 + fb_info.flags = FBINFO_HWACCEL_YPAN; 698 698 fb_info.pseudo_palette = current_par.pseudo_palette; 699 699 700 700 strcpy(fb_info.fix.id, "Acorn");
+1 -1
drivers/video/fbdev/g364fb.c
··· 219 219 fb_info.screen_base = (char *) G364_MEM_BASE; /* virtual kernel address */ 220 220 fb_info.var = fb_var; 221 221 fb_info.fix = fb_fix; 222 - fb_info.flags = FBINFO_DEFAULT | FBINFO_HWACCEL_YPAN; 222 + fb_info.flags = FBINFO_HWACCEL_YPAN; 223 223 224 224 fb_alloc_cmap(&fb_info.cmap, 255, 0); 225 225
-1
drivers/video/fbdev/hpfb.c
··· 287 287 else 288 288 strcat(fb_info.fix.id, "Catseye"); 289 289 fb_info.fbops = &hpfb_ops; 290 - fb_info.flags = FBINFO_DEFAULT; 291 290 fb_info.var = hpfb_defined; 292 291 fb_info.screen_base = (char *)fb_start; 293 292
-1
drivers/video/fbdev/macfb.c
··· 876 876 fb_info.var = macfb_defined; 877 877 fb_info.fix = macfb_fix; 878 878 fb_info.pseudo_palette = pseudo_palette; 879 - fb_info.flags = FBINFO_DEFAULT; 880 879 881 880 err = fb_alloc_cmap(&fb_info.cmap, video_cmap_len, 0); 882 881 if (err)
-1
drivers/video/fbdev/maxinefb.c
··· 155 155 fb_info.screen_base = (char *)maxinefb_fix.smem_start; 156 156 fb_info.var = maxinefb_defined; 157 157 fb_info.fix = maxinefb_fix; 158 - fb_info.flags = FBINFO_DEFAULT; 159 158 160 159 fb_alloc_cmap(&fb_info.cmap, 256, 0); 161 160