Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drm: Remove flag FBINFO_DEFAULT from fbdev emulation

The flag FBINFO_DEFAULT is 0 and has no effect, as struct fbinfo.flags
has been allocated to zero by framebuffer_alloc(). So do not set it.

Flags should signal differences from the default values. After cleaning
up all occurrences of FBINFO_DEFAULT, the token will be removed.

v2:
* fix commit message (Miguel)

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Acked-by: Sam Ravnborg <sam@ravnborg.org>
Cc: Patrik Jakobsson <patrik.r.jakobsson@gmail.com>
Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: "Christian König" <christian.koenig@amd.com>
Cc: "Pan, Xinhui" <Xinhui.Pan@amd.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20230715185343.7193-2-tzimmermann@suse.de

+2 -4
-1
drivers/gpu/drm/drm_fbdev_dma.c
··· 123 123 drm_fb_helper_fill_info(info, fb_helper, sizes); 124 124 125 125 info->fbops = &drm_fbdev_dma_fb_ops; 126 - info->flags = FBINFO_DEFAULT; 127 126 128 127 /* screen */ 129 128 info->flags |= FBINFO_VIRTFB; /* system memory */
-1
drivers/gpu/drm/drm_fbdev_generic.c
··· 109 109 drm_fb_helper_fill_info(info, fb_helper, sizes); 110 110 111 111 info->fbops = &drm_fbdev_generic_fb_ops; 112 - info->flags = FBINFO_DEFAULT; 113 112 114 113 /* screen */ 115 114 info->flags |= FBINFO_VIRTFB | FBINFO_READS_FAST;
+1 -1
drivers/gpu/drm/gma500/fbdev.c
··· 215 215 } 216 216 217 217 info->fbops = &psb_fbdev_fb_ops; 218 - info->flags = FBINFO_DEFAULT; 218 + 219 219 /* Accessed stolen memory directly */ 220 220 info->screen_base = dev_priv->vram_addr + backing->offset; 221 221 info->screen_size = size;
+1 -1
drivers/gpu/drm/radeon/radeon_fbdev.c
··· 253 253 } 254 254 255 255 info->fbops = &radeon_fbdev_fb_ops; 256 - info->flags = FBINFO_DEFAULT; 256 + 257 257 /* radeon resume is fragile and needs a vt switch to help it along */ 258 258 info->skip_vt_switch = false; 259 259