Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

iio: magnetometer: hid-sensor-magn-3d: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new() which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20230919174931.1417681-41-u.kleine-koenig@pengutronix.de
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

authored by

Uwe Kleine-König and committed by
Jonathan Cameron
622adde5 4235ac7e

+2 -4
+2 -4
drivers/iio/magnetometer/hid-sensor-magn-3d.c
··· 547 547 } 548 548 549 549 /* Function to deinitialize the processing for usage id */ 550 - static int hid_magn_3d_remove(struct platform_device *pdev) 550 + static void hid_magn_3d_remove(struct platform_device *pdev) 551 551 { 552 552 struct hid_sensor_hub_device *hsdev = pdev->dev.platform_data; 553 553 struct iio_dev *indio_dev = platform_get_drvdata(pdev); ··· 556 556 sensor_hub_remove_callback(hsdev, HID_USAGE_SENSOR_COMPASS_3D); 557 557 iio_device_unregister(indio_dev); 558 558 hid_sensor_remove_trigger(indio_dev, &magn_state->magn_flux_attributes); 559 - 560 - return 0; 561 559 } 562 560 563 561 static const struct platform_device_id hid_magn_3d_ids[] = { ··· 574 576 .pm = &hid_sensor_pm_ops, 575 577 }, 576 578 .probe = hid_magn_3d_probe, 577 - .remove = hid_magn_3d_remove, 579 + .remove_new = hid_magn_3d_remove, 578 580 }; 579 581 module_platform_driver(hid_magn_3d_platform_driver); 580 582