Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

iio: light: lm3533-als: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new() which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20230919174931.1417681-40-u.kleine-koenig@pengutronix.de
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

authored by

Uwe Kleine-König and committed by
Jonathan Cameron
4235ac7e c707ccc7

+2 -4
+2 -4
drivers/iio/light/lm3533-als.c
··· 895 895 return ret; 896 896 } 897 897 898 - static int lm3533_als_remove(struct platform_device *pdev) 898 + static void lm3533_als_remove(struct platform_device *pdev) 899 899 { 900 900 struct iio_dev *indio_dev = platform_get_drvdata(pdev); 901 901 struct lm3533_als *als = iio_priv(indio_dev); ··· 905 905 lm3533_als_disable(als); 906 906 if (als->irq) 907 907 free_irq(als->irq, indio_dev); 908 - 909 - return 0; 910 908 } 911 909 912 910 static struct platform_driver lm3533_als_driver = { ··· 912 914 .name = "lm3533-als", 913 915 }, 914 916 .probe = lm3533_als_probe, 915 - .remove = lm3533_als_remove, 917 + .remove_new = lm3533_als_remove, 916 918 }; 917 919 module_platform_driver(lm3533_als_driver); 918 920