Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

clk: fixed-rate: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20230312161512.2715500-11-u.kleine-koenig@pengutronix.de
Signed-off-by: Stephen Boyd <sboyd@kernel.org>

authored by

Uwe Kleine-König and committed by
Stephen Boyd
57e20d68 6f149b65

+2 -4
+2 -4
drivers/clk/clk-fixed-rate.c
··· 196 196 } 197 197 CLK_OF_DECLARE(fixed_clk, "fixed-clock", of_fixed_clk_setup); 198 198 199 - static int of_fixed_clk_remove(struct platform_device *pdev) 199 + static void of_fixed_clk_remove(struct platform_device *pdev) 200 200 { 201 201 struct clk_hw *hw = platform_get_drvdata(pdev); 202 202 203 203 of_clk_del_provider(pdev->dev.of_node); 204 204 clk_hw_unregister_fixed_rate(hw); 205 - 206 - return 0; 207 205 } 208 206 209 207 static int of_fixed_clk_probe(struct platform_device *pdev) ··· 232 234 .of_match_table = of_fixed_clk_ids, 233 235 }, 234 236 .probe = of_fixed_clk_probe, 235 - .remove = of_fixed_clk_remove, 237 + .remove_new = of_fixed_clk_remove, 236 238 }; 237 239 builtin_platform_driver(of_fixed_clk_driver); 238 240 #endif