Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

scsi: ppa: use sg helper to iterate over scatterlist

Unlike the legacy I/O path, scsi-mq preallocates a large array to hold
the scatterlist for each request. This static allocation can consume
substantial amounts of memory on modern controllers which support a
large number of concurrently outstanding requests.

To facilitate a switch to a smaller static allocation combined with a
dynamic allocation for requests that need it, we need to make sure all
SCSI drivers handle chained scatterlists correctly.

Convert remaining drivers that directly dereference the scatterlist
array to using the iterator functions.

[mkp: clarified commit message]

Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Ming Lei <ming.lei@redhat.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

authored by

Ming Lei and committed by
Martin K. Petersen
57ef4e51 1b3a4640

+1 -1
+1 -1
drivers/scsi/ppa.c
··· 590 590 if (cmd->SCp.buffer && !cmd->SCp.this_residual) { 591 591 /* if scatter/gather, advance to the next segment */ 592 592 if (cmd->SCp.buffers_residual--) { 593 - cmd->SCp.buffer++; 593 + cmd->SCp.buffer = sg_next(cmd->SCp.buffer); 594 594 cmd->SCp.this_residual = 595 595 cmd->SCp.buffer->length; 596 596 cmd->SCp.ptr = sg_virt(cmd->SCp.buffer);