Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

scsi: pcmcia: nsp_cs: use sg helper to iterate over scatterlist

Unlike the legacy I/O path, scsi-mq preallocates a large array to hold
the scatterlist for each request. This static allocation can consume
substantial amounts of memory on modern controllers which support a
large number of concurrently outstanding requests.

To facilitate a switch to a smaller static allocation combined with a
dynamic allocation for requests that need it, we need to make sure all
SCSI drivers handle chained scatterlists correctly.

Convert remaining drivers that directly dereference the scatterlist
array to using the iterator functions.

[mkp: clarified commit message]

Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Ming Lei <ming.lei@redhat.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

authored by

Ming Lei and committed by
Martin K. Petersen
1b3a4640 79da19b4

+2 -2
+2 -2
drivers/scsi/pcmcia/nsp_cs.c
··· 789 789 SCpnt->SCp.buffers_residual != 0 ) { 790 790 //nsp_dbg(NSP_DEBUG_DATA_IO, "scatterlist next timeout=%d", time_out); 791 791 SCpnt->SCp.buffers_residual--; 792 - SCpnt->SCp.buffer++; 792 + SCpnt->SCp.buffer = sg_next(SCpnt->SCp.buffer); 793 793 SCpnt->SCp.ptr = BUFFER_ADDR; 794 794 SCpnt->SCp.this_residual = SCpnt->SCp.buffer->length; 795 795 time_out = 1000; ··· 887 887 SCpnt->SCp.buffers_residual != 0 ) { 888 888 //nsp_dbg(NSP_DEBUG_DATA_IO, "scatterlist next"); 889 889 SCpnt->SCp.buffers_residual--; 890 - SCpnt->SCp.buffer++; 890 + SCpnt->SCp.buffer = sg_next(SCpnt->SCp.buffer); 891 891 SCpnt->SCp.ptr = BUFFER_ADDR; 892 892 SCpnt->SCp.this_residual = SCpnt->SCp.buffer->length; 893 893 time_out = 1000;