Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

net: usb: Delete unnecessary checks before the macro call “dev_kfree_skb”

The dev_kfree_skb() function performs also input parameter validation.
Thus the test around the shown calls is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: David S. Miller <davem@davemloft.net>

authored by

Markus Elfring and committed by
David S. Miller
5477fccf b7deac31

+3 -7
+1 -3
drivers/net/usb/lg-vl600.c
··· 87 87 { 88 88 struct vl600_state *s = dev->driver_priv; 89 89 90 - if (s->current_rx_buf) 91 - dev_kfree_skb(s->current_rx_buf); 92 - 90 + dev_kfree_skb(s->current_rx_buf); 93 91 kfree(s); 94 92 95 93 return usbnet_cdc_unbind(dev, intf);
+2 -4
drivers/net/usb/rtl8150.c
··· 586 586 int i; 587 587 588 588 for (i = 0; i < RX_SKB_POOL_SIZE; i++) 589 - if (dev->rx_skb_pool[i]) 590 - dev_kfree_skb(dev->rx_skb_pool[i]); 589 + dev_kfree_skb(dev->rx_skb_pool[i]); 591 590 } 592 591 593 592 static void rx_fixup(unsigned long data) ··· 945 946 unlink_all_urbs(dev); 946 947 free_all_urbs(dev); 947 948 free_skb_pool(dev); 948 - if (dev->rx_skb) 949 - dev_kfree_skb(dev->rx_skb); 949 + dev_kfree_skb(dev->rx_skb); 950 950 kfree(dev->intr_buff); 951 951 free_netdev(dev->netdev); 952 952 }