Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

ARM: dts: exynos: Correct USB3503 GPIOs polarity

Current USB3503 driver ignores GPIO polarity and always operates as if the
GPIO lines were flagged as ACTIVE_HIGH. Fix the polarity for the existing
USB3503 chip applications to match the chip specification and common
convention for naming the pins. The only pin, which has to be ACTIVE_LOW
is the reset pin. The remaining are ACTIVE_HIGH. This change allows later
to fix the USB3503 driver to properly use generic GPIO bindings and read
polarity from DT.

Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>

authored by

Marek Szyprowski and committed by
Krzysztof Kozlowski
5206265f eaffc4de

+3 -3
+1 -1
arch/arm/boot/dts/exynos4412-odroid-common.dtsi
··· 267 267 268 268 intn-gpios = <&gpx3 0 GPIO_ACTIVE_HIGH>; 269 269 connect-gpios = <&gpx3 4 GPIO_ACTIVE_HIGH>; 270 - reset-gpios = <&gpx3 5 GPIO_ACTIVE_HIGH>; 270 + reset-gpios = <&gpx3 5 GPIO_ACTIVE_LOW>; 271 271 initial-mode = <1>; 272 272 }; 273 273
+1 -1
arch/arm/boot/dts/exynos5250-arndale.dts
··· 154 154 compatible = "smsc,usb3503a"; 155 155 156 156 reset-gpios = <&gpx3 5 GPIO_ACTIVE_LOW>; 157 - connect-gpios = <&gpd1 7 GPIO_ACTIVE_LOW>; 157 + connect-gpios = <&gpd1 7 GPIO_ACTIVE_HIGH>; 158 158 }; 159 159 }; 160 160
+1 -1
arch/arm/boot/dts/exynos5410-odroidxu.dts
··· 170 170 171 171 intn-gpios = <&gpx0 7 GPIO_ACTIVE_HIGH>; 172 172 connect-gpios = <&gpx0 6 GPIO_ACTIVE_HIGH>; 173 - reset-gpios = <&gpx1 4 GPIO_ACTIVE_HIGH>; 173 + reset-gpios = <&gpx1 4 GPIO_ACTIVE_LOW>; 174 174 initial-mode = <1>; 175 175 176 176 clock-names = "refclk";