Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

clk: imx31: add missing of_node_put

for_each_compatible_node performs an of_node_get on each iteration, so a
break out of the loop requires an of_node_put.

The semantic patch that fixes this problem is as follows
(http://coccinelle.lip6.fr):

// <smpl>
@@
local idexpression n;
expression e;
@@

for_each_compatible_node(n,...) {
...
(
of_node_put(n);
|
e = n
|
+ of_node_put(n);
? break;
)
...
}
... when != n
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>

authored by

Julia Lawall and committed by
Stephen Boyd
489e5d41 77cb8ee6

+3 -1
+3 -1
drivers/clk/imx/clk-imx31.c
··· 233 233 if (!of_device_is_compatible(np, "fsl,imx-osc26m")) 234 234 continue; 235 235 236 - if (!of_property_read_u32(np, "clock-frequency", &fref)) 236 + if (!of_property_read_u32(np, "clock-frequency", &fref)) { 237 + of_node_put(np); 237 238 break; 239 + } 238 240 } 239 241 240 242 _mx31_clocks_init(fref);