Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

clk: imx27: add missing of_node_put

for_each_compatible_node performs an of_node_get on each iteration, so a
break out of the loop requires an of_node_put.

The semantic patch that fixes this problem is as follows
(http://coccinelle.lip6.fr):

// <smpl>
@@
local idexpression n;
expression e;
@@

for_each_compatible_node(n,...) {
...
(
of_node_put(n);
|
e = n
|
+ of_node_put(n);
? break;
)
...
}
... when != n
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>

authored by

Julia Lawall and committed by
Stephen Boyd
77cb8ee6 a1bdfbaf

+3 -1
+3 -1
drivers/clk/imx/clk-imx27.c
··· 261 261 if (!of_device_is_compatible(refnp, "fsl,imx-osc26m")) 262 262 continue; 263 263 264 - if (!of_property_read_u32(refnp, "clock-frequency", &fref)) 264 + if (!of_property_read_u32(refnp, "clock-frequency", &fref)) { 265 + of_node_put(refnp); 265 266 break; 267 + } 266 268 } 267 269 268 270 ccm = of_iomap(np, 0);