Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

PCI: Remove unused pci_vpd_truncate()

My philosophy is unused code is dead code. And dead code is subject to bit
rot and is a likely source of bugs. Use it or lose it.

This reverts db5679437a2b ("PCI: add interface to set visible size of
VPD"), removing this interface:

pci_vpd_truncate()

[bhelgaas: split to separate patch, also remove prototype from pci.h]
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>

authored by

Stephen Hemminger and committed by
Bjorn Helgaas
3984ca1c 7c2dd2d7

-25
-24
drivers/pci/access.c
··· 381 381 } 382 382 383 383 /** 384 - * pci_vpd_truncate - Set available Vital Product Data size 385 - * @dev: pci device struct 386 - * @size: available memory in bytes 387 - * 388 - * Adjust size of available VPD area. 389 - */ 390 - int pci_vpd_truncate(struct pci_dev *dev, size_t size) 391 - { 392 - if (!dev->vpd) 393 - return -EINVAL; 394 - 395 - /* limited by the access method */ 396 - if (size > dev->vpd->len) 397 - return -EINVAL; 398 - 399 - dev->vpd->len = size; 400 - if (dev->vpd->attr) 401 - dev->vpd->attr->size = size; 402 - 403 - return 0; 404 - } 405 - EXPORT_SYMBOL(pci_vpd_truncate); 406 - 407 - /** 408 384 * pci_cfg_access_lock - Lock PCI config reads/writes 409 385 * @dev: pci device struct 410 386 *
-1
include/linux/pci.h
··· 1009 1009 /* Vital product data routines */ 1010 1010 ssize_t pci_read_vpd(struct pci_dev *dev, loff_t pos, size_t count, void *buf); 1011 1011 ssize_t pci_write_vpd(struct pci_dev *dev, loff_t pos, size_t count, const void *buf); 1012 - int pci_vpd_truncate(struct pci_dev *dev, size_t size); 1013 1012 1014 1013 /* Helper functions for low-level code (drivers/pci/setup-[bus,res].c) */ 1015 1014 resource_size_t pcibios_retrieve_fw_addr(struct pci_dev *dev, int idx);