Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

PCI: Remove unused ID-Based Ordering support

My philosophy is unused code is dead code. And dead code is subject to bit
rot and is a likely source of bugs. Use it or lose it.

This reverts b48d4425b602 ("PCI: add ID-based ordering enable/disable
support"), removing these interfaces:

pci_enable_ido()
pci_disable_ido()

[bhelgaas: split to separate patch, also remove prototypes from pci.h]
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
CC: Jesse Barnes <jbarnes@virtuousgeek.org>

authored by

Stephen Hemminger and committed by
Bjorn Helgaas
7c2dd2d7 ecc86356

-53
-40
drivers/pci/pci.c
··· 2110 2110 } 2111 2111 } 2112 2112 2113 - /** 2114 - * pci_enable_ido - enable ID-based Ordering on a device 2115 - * @dev: the PCI device 2116 - * @type: which types of IDO to enable 2117 - * 2118 - * Enable ID-based ordering on @dev. @type can contain the bits 2119 - * %PCI_EXP_IDO_REQUEST and/or %PCI_EXP_IDO_COMPLETION to indicate 2120 - * which types of transactions are allowed to be re-ordered. 2121 - */ 2122 - void pci_enable_ido(struct pci_dev *dev, unsigned long type) 2123 - { 2124 - u16 ctrl = 0; 2125 - 2126 - if (type & PCI_EXP_IDO_REQUEST) 2127 - ctrl |= PCI_EXP_DEVCTL2_IDO_REQ_EN; 2128 - if (type & PCI_EXP_IDO_COMPLETION) 2129 - ctrl |= PCI_EXP_DEVCTL2_IDO_CMP_EN; 2130 - if (ctrl) 2131 - pcie_capability_set_word(dev, PCI_EXP_DEVCTL2, ctrl); 2132 - } 2133 - EXPORT_SYMBOL(pci_enable_ido); 2134 - 2135 - /** 2136 - * pci_disable_ido - disable ID-based ordering on a device 2137 - * @dev: the PCI device 2138 - * @type: which types of IDO to disable 2139 - */ 2140 - void pci_disable_ido(struct pci_dev *dev, unsigned long type) 2141 - { 2142 - u16 ctrl = 0; 2143 - 2144 - if (type & PCI_EXP_IDO_REQUEST) 2145 - ctrl |= PCI_EXP_DEVCTL2_IDO_REQ_EN; 2146 - if (type & PCI_EXP_IDO_COMPLETION) 2147 - ctrl |= PCI_EXP_DEVCTL2_IDO_CMP_EN; 2148 - if (ctrl) 2149 - pcie_capability_clear_word(dev, PCI_EXP_DEVCTL2, ctrl); 2150 - } 2151 - EXPORT_SYMBOL(pci_disable_ido); 2152 - 2153 2113 static int pci_acs_enable; 2154 2114 2155 2115 /**
-13
include/linux/pci.h
··· 997 997 return __pci_enable_wake(dev, state, false, enable); 998 998 } 999 999 1000 - #define PCI_EXP_IDO_REQUEST (1<<0) 1001 - #define PCI_EXP_IDO_COMPLETION (1<<1) 1002 - void pci_enable_ido(struct pci_dev *dev, unsigned long type); 1003 - void pci_disable_ido(struct pci_dev *dev, unsigned long type); 1004 - 1005 1000 /* For use by arch with custom probe code */ 1006 1001 void set_pcie_port_type(struct pci_dev *pdev); 1007 1002 void set_pcie_hotplug_bridge(struct pci_dev *pdev); ··· 1405 1410 int enable) 1406 1411 { 1407 1412 return 0; 1408 - } 1409 - 1410 - static inline void pci_enable_ido(struct pci_dev *dev, unsigned long type) 1411 - { 1412 - } 1413 - 1414 - static inline void pci_disable_ido(struct pci_dev *dev, unsigned long type) 1415 - { 1416 1413 } 1417 1414 1418 1415 static inline int pci_request_regions(struct pci_dev *dev, const char *res_name)