Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

mfd: intel_soc_pmic_chtwc: Use dev_err_probe()

Simplify the mux error path a bit by using dev_err_probe().

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Link: https://lore.kernel.org/r/20220616171009.43524-1-andriy.shevchenko@linux.intel.com

authored by

Andy Shevchenko and committed by
Lee Jones
352de780 c5533306

+7 -12
+7 -12
drivers/mfd/intel_soc_pmic_chtwc.c
··· 179 179 int ret; 180 180 181 181 status = acpi_evaluate_integer(ACPI_HANDLE(dev), "_HRV", NULL, &hrv); 182 - if (ACPI_FAILURE(status)) { 183 - dev_err(dev, "Failed to get PMIC hardware revision\n"); 184 - return -ENODEV; 185 - } 186 - if (hrv != CHT_WC_HRV) { 187 - dev_err(dev, "Invalid PMIC hardware revision: %llu\n", hrv); 188 - return -ENODEV; 189 - } 190 - if (client->irq < 0) { 191 - dev_err(dev, "Invalid IRQ\n"); 192 - return -EINVAL; 193 - } 182 + if (ACPI_FAILURE(status)) 183 + return dev_err_probe(dev, -ENODEV, "Failed to get PMIC hardware revision\n"); 184 + if (hrv != CHT_WC_HRV) 185 + return dev_err_probe(dev, -ENODEV, "Invalid PMIC hardware revision: %llu\n", hrv); 186 + 187 + if (client->irq < 0) 188 + return dev_err_probe(dev, -EINVAL, "Invalid IRQ\n"); 194 189 195 190 pmic = devm_kzalloc(dev, sizeof(*pmic), GFP_KERNEL); 196 191 if (!pmic)