Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

mfd: tc6393xb: Make disable callback return void

All implementations return 0, so simplify accordingly.

This is a preparation for making platform remove callbacks return void.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Link: https://lore.kernel.org/r/20220619082655.53728-1-u.kleine-koenig@pengutronix.de

authored by

Uwe Kleine-König and committed by
Lee Jones
c5533306 99a7ec2f

+5 -9
+1 -2
arch/arm/mach-pxa/eseries.c
··· 86 86 return 0; 87 87 } 88 88 89 - int eseries_tmio_disable(struct platform_device *dev) 89 + void eseries_tmio_disable(struct platform_device *dev) 90 90 { 91 91 gpio_set_value(GPIO_ESERIES_TMIO_SUSPEND, 0); 92 92 gpio_set_value(GPIO_ESERIES_TMIO_PCLR, 0); 93 - return 0; 94 93 } 95 94 96 95 int eseries_tmio_suspend(struct platform_device *dev)
+1 -3
arch/arm/mach-pxa/tosa.c
··· 678 678 return rc; 679 679 } 680 680 681 - static int tosa_tc6393xb_disable(struct platform_device *dev) 681 + static void tosa_tc6393xb_disable(struct platform_device *dev) 682 682 { 683 683 gpio_free(TOSA_GPIO_TC6393XB_L3V_ON); 684 684 gpio_free(TOSA_GPIO_TC6393XB_SUSPEND); 685 685 gpio_free(TOSA_GPIO_TC6393XB_REST_IN); 686 - 687 - return 0; 688 686 } 689 687 690 688 static int tosa_tc6393xb_resume(struct platform_device *dev)
+2 -3
drivers/mfd/tc6393xb.c
··· 798 798 { 799 799 struct tc6393xb_platform_data *tcpd = dev_get_platdata(&dev->dev); 800 800 struct tc6393xb *tc6393xb = platform_get_drvdata(dev); 801 - int ret; 802 801 803 802 mfd_remove_devices(&dev->dev); 804 803 805 804 tc6393xb_detach_irq(dev); 806 805 807 - ret = tcpd->disable(dev); 806 + tcpd->disable(dev); 808 807 clk_disable_unprepare(tc6393xb->clk); 809 808 iounmap(tc6393xb->scr); 810 809 release_resource(&tc6393xb->rscr); 811 810 clk_put(tc6393xb->clk); 812 811 kfree(tc6393xb); 813 812 814 - return ret; 813 + return 0; 815 814 } 816 815 817 816 #ifdef CONFIG_PM
+1 -1
include/linux/mfd/tc6393xb.h
··· 22 22 u16 scr_gper; /* GP Enable */ 23 23 24 24 int (*enable)(struct platform_device *dev); 25 - int (*disable)(struct platform_device *dev); 25 + void (*disable)(struct platform_device *dev); 26 26 int (*suspend)(struct platform_device *dev); 27 27 int (*resume)(struct platform_device *dev); 28 28