Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

b43legacy: no need to check return value of debugfs_create functions

When calling debugfs functions, there is no need to ever check the
return value. The function can work or not, but the code logic should
never do something different based on this.

Cc: Larry Finger <Larry.Finger@lwfinger.net>
Cc: Kalle Valo <kvalo@codeaurora.org>
Cc: linux-wireless@vger.kernel.org
Cc: b43-dev@lists.infradead.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>

authored by

Greg Kroah-Hartman and committed by
Kalle Valo
32b4ebfe e9bdcdc7

+8 -27
+8 -27
drivers/net/wireless/broadcom/b43legacy/debugfs.c
··· 361 361 static void b43legacy_add_dynamic_debug(struct b43legacy_wldev *dev) 362 362 { 363 363 struct b43legacy_dfsentry *e = dev->dfsentry; 364 - struct dentry *d; 365 364 366 - #define add_dyn_dbg(name, id, initstate) do { \ 367 - e->dyn_debug[id] = (initstate); \ 368 - d = debugfs_create_bool(name, 0600, e->subdir, \ 369 - &(e->dyn_debug[id])); \ 370 - if (!IS_ERR(d)) \ 371 - e->dyn_debug_dentries[id] = d; \ 372 - } while (0) 365 + #define add_dyn_dbg(name, id, initstate) do { \ 366 + e->dyn_debug[id] = (initstate); \ 367 + e->dyn_debug_dentries[id] = \ 368 + debugfs_create_bool(name, 0600, e->subdir, \ 369 + &(e->dyn_debug[id])); \ 370 + } while (0) 373 371 374 372 add_dyn_dbg("debug_xmitpower", B43legacy_DBG_XMITPOWER, false); 375 373 add_dyn_dbg("debug_dmaoverflow", B43legacy_DBG_DMAOVERFLOW, false); ··· 406 408 407 409 snprintf(devdir, sizeof(devdir), "%s", wiphy_name(dev->wl->hw->wiphy)); 408 410 e->subdir = debugfs_create_dir(devdir, rootdir); 409 - if (!e->subdir || IS_ERR(e->subdir)) { 410 - if (e->subdir == ERR_PTR(-ENODEV)) { 411 - b43legacydbg(dev->wl, "DebugFS (CONFIG_DEBUG_FS) not " 412 - "enabled in kernel config\n"); 413 - } else { 414 - b43legacyerr(dev->wl, "debugfs: cannot create %s directory\n", 415 - devdir); 416 - } 417 - dev->dfsentry = NULL; 418 - kfree(log->log); 419 - kfree(e); 420 - return; 421 - } 422 411 423 412 #define ADD_FILE(name, mode) \ 424 413 do { \ 425 - struct dentry *d; \ 426 - d = debugfs_create_file(__stringify(name), \ 414 + e->file_##name.dentry = \ 415 + debugfs_create_file(__stringify(name), \ 427 416 mode, e->subdir, dev, \ 428 417 &fops_##name.fops); \ 429 418 e->file_##name.dentry = NULL; \ 430 - if (!IS_ERR(d)) \ 431 - e->file_##name.dentry = d; \ 432 419 } while (0) 433 420 434 421 ··· 475 492 void b43legacy_debugfs_init(void) 476 493 { 477 494 rootdir = debugfs_create_dir(KBUILD_MODNAME, NULL); 478 - if (IS_ERR(rootdir)) 479 - rootdir = NULL; 480 495 } 481 496 482 497 void b43legacy_debugfs_exit(void)