Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

b43: no need to check return value of debugfs_create functions

When calling debugfs functions, there is no need to ever check the
return value. The function can work or not, but the code logic should
never do something different based on this.

Cc: Kalle Valo <kvalo@codeaurora.org>
Cc: linux-wireless@vger.kernel.org
Cc: b43-dev@lists.infradead.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>

authored by

Greg Kroah-Hartman and committed by
Kalle Valo
e9bdcdc7 80f4c5e3

+8 -28
+8 -28
drivers/net/wireless/broadcom/b43/debugfs.c
··· 668 668 static void b43_add_dynamic_debug(struct b43_wldev *dev) 669 669 { 670 670 struct b43_dfsentry *e = dev->dfsentry; 671 - struct dentry *d; 672 671 673 - #define add_dyn_dbg(name, id, initstate) do { \ 674 - e->dyn_debug[id] = (initstate); \ 675 - d = debugfs_create_bool(name, 0600, e->subdir, \ 676 - &(e->dyn_debug[id])); \ 677 - if (!IS_ERR(d)) \ 678 - e->dyn_debug_dentries[id] = d; \ 679 - } while (0) 672 + #define add_dyn_dbg(name, id, initstate) do { \ 673 + e->dyn_debug[id] = (initstate); \ 674 + e->dyn_debug_dentries[id] = \ 675 + debugfs_create_bool(name, 0600, e->subdir, \ 676 + &(e->dyn_debug[id])); \ 677 + } while (0) 680 678 681 679 add_dyn_dbg("debug_xmitpower", B43_DBG_XMITPOWER, false); 682 680 add_dyn_dbg("debug_dmaoverflow", B43_DBG_DMAOVERFLOW, false); ··· 716 718 717 719 snprintf(devdir, sizeof(devdir), "%s", wiphy_name(dev->wl->hw->wiphy)); 718 720 e->subdir = debugfs_create_dir(devdir, rootdir); 719 - if (!e->subdir || IS_ERR(e->subdir)) { 720 - if (e->subdir == ERR_PTR(-ENODEV)) { 721 - b43dbg(dev->wl, "DebugFS (CONFIG_DEBUG_FS) not " 722 - "enabled in kernel config\n"); 723 - } else { 724 - b43err(dev->wl, "debugfs: cannot create %s directory\n", 725 - devdir); 726 - } 727 - dev->dfsentry = NULL; 728 - kfree(log->log); 729 - kfree(e); 730 - return; 731 - } 732 721 733 722 e->mmio16read_next = 0xFFFF; /* invalid address */ 734 723 e->mmio32read_next = 0xFFFF; /* invalid address */ ··· 726 741 727 742 #define ADD_FILE(name, mode) \ 728 743 do { \ 729 - struct dentry *d; \ 730 - d = debugfs_create_file(__stringify(name), \ 744 + e->file_##name.dentry = \ 745 + debugfs_create_file(__stringify(name), \ 731 746 mode, e->subdir, dev, \ 732 747 &fops_##name.fops); \ 733 - e->file_##name.dentry = NULL; \ 734 - if (!IS_ERR(d)) \ 735 - e->file_##name.dentry = d; \ 736 748 } while (0) 737 749 738 750 ··· 800 818 void b43_debugfs_init(void) 801 819 { 802 820 rootdir = debugfs_create_dir(KBUILD_MODNAME, NULL); 803 - if (IS_ERR(rootdir)) 804 - rootdir = NULL; 805 821 } 806 822 807 823 void b43_debugfs_exit(void)