Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

ide: convert ide_hwif_t.mmio into flag (v2)

All users of ->mmio == 1 are gone so convert ->mmio into flag.

Noticed by Alan Cox.

v2:
* updated for scc_pata

Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>

+23 -22
+1 -1
drivers/ide/arm/icside.c
··· 556 556 * Ensure we're using MMIO 557 557 */ 558 558 default_hwif_mmiops(hwif); 559 - hwif->mmio = 2; 559 + hwif->mmio = 1; 560 560 561 561 for (i = IDE_DATA_OFFSET; i <= IDE_STATUS_OFFSET; i++) { 562 562 hwif->hw.io_ports[i] = port;
+1 -1
drivers/ide/arm/rapide.c
··· 46 46 hwif->hw.io_ports[IDE_CONTROL_OFFSET] = (unsigned long)ctrl; 47 47 hwif->io_ports[IDE_CONTROL_OFFSET] = (unsigned long)ctrl; 48 48 hwif->hw.irq = hwif->irq = irq; 49 - hwif->mmio = 2; 49 + hwif->mmio = 1; 50 50 default_hwif_mmiops(hwif); 51 51 52 52 return hwif;
+1 -1
drivers/ide/cris/ide-cris.c
··· 795 795 0, 0, cris_ide_ack_intr, 796 796 ide_default_irq(0)); 797 797 ide_register_hw(&hw, &hwif); 798 - hwif->mmio = 2; 798 + hwif->mmio = 1; 799 799 hwif->chipset = ide_etrax100; 800 800 hwif->tuneproc = &tune_cris_ide; 801 801 hwif->speedproc = &speed_cris_ide;
+1 -1
drivers/ide/h8300/ide-h8300.c
··· 76 76 { 77 77 default_hwif_iops(hwif); 78 78 79 - hwif->mmio = 2; 79 + hwif->mmio = 1; 80 80 hwif->OUTW = mm_outw; 81 81 hwif->OUTSW = mm_outsw; 82 82 hwif->INW = mm_inw;
+4 -4
drivers/ide/ide-dma.c
··· 565 565 } 566 566 567 567 /* PRD table */ 568 - if (hwif->mmio == 2) 568 + if (hwif->mmio) 569 569 writel(hwif->dmatable_dma, (void __iomem *)hwif->dma_prdtable); 570 570 else 571 571 outl(hwif->dmatable_dma, hwif->dma_prdtable); ··· 815 815 { 816 816 ide_release_dma_engine(hwif); 817 817 818 - if (hwif->mmio == 2) 818 + if (hwif->mmio) 819 819 return 1; 820 820 else 821 821 return ide_release_iomio_dma(hwif); ··· 884 884 885 885 static int ide_dma_iobase(ide_hwif_t *hwif, unsigned long base, unsigned int ports) 886 886 { 887 - if (hwif->mmio == 2) 887 + if (hwif->mmio) 888 888 return ide_mapped_mmio_dma(hwif, base,ports); 889 - BUG_ON(hwif->mmio == 1); 889 + 890 890 return ide_iomio_dma(hwif, base, ports); 891 891 } 892 892
+2 -3
drivers/ide/ide.c
··· 389 389 unsigned long addr; 390 390 unsigned int i; 391 391 392 - if (hwif->mmio == 2) 392 + if (hwif->mmio) 393 393 return 0; 394 - BUG_ON(hwif->mmio == 1); 395 394 addr = hwif->io_ports[IDE_CONTROL_OFFSET]; 396 395 if (addr && !hwif_request_region(hwif, addr, 1)) 397 396 goto control_region_busy; ··· 437 438 { 438 439 u32 i = 0; 439 440 440 - if (hwif->mmio == 2) 441 + if (hwif->mmio) 441 442 return; 442 443 if (hwif->io_ports[IDE_CONTROL_OFFSET]) 443 444 release_region(hwif->io_ports[IDE_CONTROL_OFFSET], 1);
+1 -1
drivers/ide/legacy/buddha.c
··· 215 215 216 216 index = ide_register_hw(&hw, &hwif); 217 217 if (index != -1) { 218 - hwif->mmio = 2; 218 + hwif->mmio = 1; 219 219 printk("ide%d: ", index); 220 220 switch(type) { 221 221 case BOARD_BUDDHA:
+1 -1
drivers/ide/legacy/gayle.c
··· 167 167 168 168 index = ide_register_hw(&hw, &hwif); 169 169 if (index != -1) { 170 - hwif->mmio = 2; 170 + hwif->mmio = 1; 171 171 switch (i) { 172 172 case 0: 173 173 printk("ide%d: Gayle IDE interface (A%d style)\n", index,
+1 -1
drivers/ide/legacy/macide.c
··· 141 141 } 142 142 143 143 if (index != -1) { 144 - hwif->mmio = 2; 144 + hwif->mmio = 1; 145 145 if (macintosh_config->ide_type == MAC_IDE_QUADRA) 146 146 printk(KERN_INFO "ide%d: Macintosh Quadra IDE interface\n", index); 147 147 else if (macintosh_config->ide_type == MAC_IDE_PB)
+1 -1
drivers/ide/legacy/q40ide.c
··· 145 145 index = ide_register_hw(&hw, &hwif); 146 146 // **FIXME** 147 147 if (index != -1) 148 - hwif->mmio = 2; 148 + hwif->mmio = 1; 149 149 } 150 150 } 151 151
+2 -1
drivers/ide/mips/au1xxx-ide.c
··· 708 708 709 709 /* hold should be on in all cases */ 710 710 hwif->hold = 1; 711 - hwif->mmio = 2; 711 + 712 + hwif->mmio = 1; 712 713 713 714 /* If the user has selected DDMA assisted copies, 714 715 then set up a few local I/O function entry points
+1 -1
drivers/ide/mips/swarm.c
··· 115 115 /* Setup MMIO ops. */ 116 116 default_hwif_mmiops(hwif); 117 117 /* Prevent resource map manipulation. */ 118 - hwif->mmio = 2; 118 + hwif->mmio = 1; 119 119 hwif->noprobe = 0; 120 120 121 121 for (i = IDE_DATA_OFFSET; i <= IDE_STATUS_OFFSET; i++)
+1 -1
drivers/ide/pci/sgiioc4.c
··· 593 593 static void __devinit 594 594 ide_init_sgiioc4(ide_hwif_t * hwif) 595 595 { 596 - hwif->mmio = 2; 596 + hwif->mmio = 1; 597 597 hwif->autodma = 1; 598 598 hwif->atapi_dma = 1; 599 599 hwif->ultra_mask = 0x0; /* Disable Ultra DMA */
+2 -1
drivers/ide/pci/siimage.c
··· 888 888 base = (unsigned long) addr; 889 889 890 890 hwif->dma_base = base + (ch ? 0x08 : 0x00); 891 - hwif->mmio = 2; 891 + 892 + hwif->mmio = 1; 892 893 } 893 894 894 895 static int is_dev_seagate_sata(ide_drive_t *drive)
+1 -1
drivers/ide/ppc/pmac.c
··· 1237 1237 hwif->OUTBSYNC = pmac_outbsync; 1238 1238 1239 1239 /* Tell common code _not_ to mess with resources */ 1240 - hwif->mmio = 2; 1240 + hwif->mmio = 1; 1241 1241 hwif->hwif_data = pmif; 1242 1242 pmac_ide_init_hwif_ports(&hwif->hw, pmif->regbase, 0, &hwif->irq); 1243 1243 memcpy(hwif->io_ports, hwif->hw.io_ports, sizeof(hwif->io_ports));
+1 -1
drivers/ide/ppc/scc_pata.c
··· 668 668 hwif->irq = hwif->pci_dev->irq; 669 669 hwif->dma_base = dma_base; 670 670 hwif->config_data = ports->ctl; 671 - hwif->mmio = 2; 671 + hwif->mmio = 1; 672 672 } 673 673 674 674 /**
+1 -1
include/linux/ide.h
··· 772 772 unsigned int cursg; 773 773 unsigned int cursg_ofs; 774 774 775 - int mmio; /* hosts iomio (0) or custom (2) select */ 776 775 int rqsize; /* max sectors per request */ 777 776 int irq; /* our irq number */ 778 777 ··· 803 804 unsigned sg_mapped : 1; /* sg_table and sg_nents are ready */ 804 805 unsigned no_io_32bit : 1; /* 1 = can not do 32-bit IO ops */ 805 806 unsigned err_stops_fifo : 1; /* 1=data FIFO is cleared by an error */ 807 + unsigned mmio : 1; /* host uses MMIO */ 806 808 807 809 struct device gendev; 808 810 struct completion gendev_rel_comp; /* To deal with device release() */