Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

media: TDA1997x: Remove redundant cancel_delayed_work in probe

The delayed_work delayed_work_enable_hpd is initialized with
INIT_DELAYED_WORK(), but it is never scheduled in tda1997x_probe().

Calling cancel_delayed_work() on a work that has never been
scheduled is redundant and unnecessary, as there is no pending
work to cancel.

Remove the redundant cancel_delayed_work() from error handling
path in tda1997x_probe() to avoid potential confusion.

Fixes: 9ac0038db9a7 ("media: i2c: Add TDA1997x HDMI receiver driver")
Cc: stable@vger.kernel.org
Signed-off-by: Duoming Zhou <duoming@zju.edu.cn>
Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>

authored by

Duoming Zhou and committed by
Hans Verkuil
29de195c 248d140a

-1
-1
drivers/media/i2c/tda1997x.c
··· 2797 2797 err_free_handler: 2798 2798 v4l2_ctrl_handler_free(&state->hdl); 2799 2799 err_free_mutex: 2800 - cancel_delayed_work(&state->delayed_work_enable_hpd); 2801 2800 mutex_destroy(&state->page_lock); 2802 2801 mutex_destroy(&state->lock); 2803 2802 tda1997x_set_power(state, 0);