Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

media: dvb: Use int type to store negative error codes

Change the 'ret' variable from u8/u32 to int to store zero or negative
error codes returned by other functions.

Storing the negative error codes in unsigned type, doesn't cause an issue
at runtime but it's ugly as pants.

No effect on runtime.

Signed-off-by: Qianfeng Rong <rongqianfeng@vivo.com>
Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>

authored by

Qianfeng Rong and committed by
Hans Verkuil
248d140a a5e4a493

+4 -3
+2 -1
drivers/media/dvb-frontends/cxd2841er.c
··· 1936 1936 { 1937 1937 struct dtv_frontend_properties *p = &fe->dtv_property_cache; 1938 1938 struct cxd2841er_priv *priv = fe->demodulator_priv; 1939 - u32 ret, bit_error = 0, bit_count = 0; 1939 + u32 bit_error = 0, bit_count = 0; 1940 + int ret; 1940 1941 1941 1942 dev_dbg(&priv->i2c->dev, "%s()\n", __func__); 1942 1943 switch (p->delivery_system) {
+2 -2
drivers/media/dvb-frontends/lgdt330x.c
··· 124 124 /* Software reset */ 125 125 static int lgdt3302_sw_reset(struct lgdt330x_state *state) 126 126 { 127 - u8 ret; 128 127 u8 reset[] = { 129 128 IRQ_MASK, 130 129 /* ··· 132 133 */ 133 134 0x00 134 135 }; 136 + int ret; 135 137 136 138 ret = i2c_write_demod_bytes(state, 137 139 reset, sizeof(reset)); ··· 147 147 148 148 static int lgdt3303_sw_reset(struct lgdt330x_state *state) 149 149 { 150 - u8 ret; 151 150 u8 reset[] = { 152 151 0x02, 153 152 0x00 /* bit 0 is active low software reset */ 154 153 }; 154 + int ret; 155 155 156 156 ret = i2c_write_demod_bytes(state, 157 157 reset, sizeof(reset));