Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

ASoC: mediatek: mt8192-afe-pcm: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Acked-by: Takashi Iwai <tiwai@suse.de>
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
Link: https://lore.kernel.org/r/20230315150745.67084-113-u.kleine-koenig@pengutronix.de
Signed-off-by: Mark Brown <broonie@kernel.org>

authored by

Uwe Kleine-König and committed by
Mark Brown
26530339 bb5ba5fe

+2 -3
+2 -3
sound/soc/mediatek/mt8192/mt8192-afe-pcm.c
··· 2349 2349 return ret; 2350 2350 } 2351 2351 2352 - static int mt8192_afe_pcm_dev_remove(struct platform_device *pdev) 2352 + static void mt8192_afe_pcm_dev_remove(struct platform_device *pdev) 2353 2353 { 2354 2354 struct mtk_base_afe *afe = platform_get_drvdata(pdev); 2355 2355 ··· 2359 2359 2360 2360 /* disable afe clock */ 2361 2361 mt8192_afe_disable_clock(afe); 2362 - return 0; 2363 2362 } 2364 2363 2365 2364 static const struct of_device_id mt8192_afe_pcm_dt_match[] = { ··· 2379 2380 .pm = &mt8192_afe_pm_ops, 2380 2381 }, 2381 2382 .probe = mt8192_afe_pcm_dev_probe, 2382 - .remove = mt8192_afe_pcm_dev_remove, 2383 + .remove_new = mt8192_afe_pcm_dev_remove, 2383 2384 }; 2384 2385 2385 2386 module_platform_driver(mt8192_afe_pcm_driver);